Commit graph

10 commits

Author SHA1 Message Date
Vincent
852a8582fb fix: Add the non-truncated text in the title attribute (#1598)
The `.card-title` element carries `text-overflow: ellipsis`, (and
`white-space: nowrap`), resulting in the last part of long article
titles not being visible. By adding it to the `title` attribute,
one can see the full title on hovering without having to visit the
article first.

The main concern I had was that the text is now technically
duplicated in the source code, and for short titles, also in the
UI. The primary concern there, however, was screen reader users
getting duplicate announcements. However, I believe the title
attribute is not announced by screen readers, which this (old)
article seems to confirm:
https://developer.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/

That leaves the following two disadvantages:
- This doesn't solve anything for mobile users, who will still
  have to follow the link to see the full title.
- Desktop users can however a (non-truncated) title to see the same
  title again.
2019-10-23 21:54:57 -07:00
Nolan Lawson
8672ade314
fix: unescape html in card titles/descriptions (#1252) 2019-05-28 22:24:16 -07:00
sgenoud
2ce2453d8f fix: Unstretch the card image (#1157)
Fix #1156
2019-04-20 07:52:14 -07:00
sgenoud
79184570b1 fix: Manage the width to take scrollbars into account (#1138)
* Manage the width to take scrollbars into account

* Additional modal layout styles changes
2019-04-13 11:02:25 -07:00
sgenoud
5642b10c72 fix: Add hostname when description is missing (#1145) 2019-04-10 07:57:37 -07:00
sgenoud
49b0633a8d feat: Add a shortcut to opening the cards link (#1134)
* Add a shortcut to opening the cards link

* minor aesthetic tweaks
2019-04-10 07:56:24 -07:00
sgenoud
1dec3b55f9 fix: Remove placeholder for cards without images (#1135)
* Remove placeholder for cards without images

* remove no longer needed svg
2019-04-08 19:14:18 -07:00
Nolan Lawson
8549c3a79a
fix: add placeholder icon for opengraph cards without images (#1131) 2019-04-01 20:48:41 -07:00
Nolan Lawson
44c45d0b64
fix: slight tweaks to opengraph card (#1128) 2019-03-31 14:11:24 -07:00
sgenoud
6bae770bf5 feat: Add support for Open Graph cards (#1121)
* Add support for Open Graph cards

* use <strong> and aria-hidden on image to improve a11y
2019-03-31 12:04:24 -07:00