Commit graph

301 commits

Author SHA1 Message Date
shine
c86d2b5088
feat: add / as a navigation shortcut for search (#1838)
`/` is a well-known vi/vim key-binding for search. It is supported by
Firefox for a 'quick find' feature in addition to the main find feature
available with the Ctrl+F key combination. DuckDuckGo also supports the
key to focus the search bar as well.

Signed-off-by: shine <4771718+shinenelson@users.noreply.github.com>
2020-08-25 16:45:32 -07:00
Nolan Lawson
b8fef16a92
fix: fix mobile size of picker when searching (#1822) 2020-07-05 12:38:05 -07:00
Nolan Lawson
f17096a8ac
fix: emoji picker height on mobile (#1811) 2020-07-04 19:34:21 -07:00
Nolan Lawson
1371175bce
feat: use emoji-picker-element, add emoji autocompletions/tooltips (#1804)
* feat: use emoji-picker-element, add emoji autocompletions/tooltips

* fix: fix lint bug

* test: fix emoji in chrome on linux in travis

* test: try bionic in travis

* chore: try to fix travis

* chore: try to fix travis

* fix: filter unsupported emoji

* chore: try to fix travis

* chore: try to fix travis

* chore: try to fix travis

* chore: try to fix travis

* Revert "chore: try to fix travis"

This reverts commit 3cd2d94469b2f1a20c847c2a69e088d7c8d1efdd.

* fix: fix emoji autosuggest

* test: fix test
2020-06-28 23:12:14 -07:00
Nolan Lawson
1fc14107c8
fix: tweak nav indicator so it's a bit more prominent (#1788) 2020-05-20 21:10:56 -07:00
Nolan Lawson
bedb636182
fix: css cleanup of nav-related variables (#1786)
* fix: css cleanup of nav-related variables

* changed my mind on this margin
2020-05-20 07:07:47 -07:00
Nolan Lawson
c610a259d5
fix: ListItem should have proper fade animations (#1771) 2020-05-14 21:22:33 -07:00
Nolan Lawson
dacd9dcc5b
fix: fix polls with content warnings (#1768)
* fix: fix polls with content warnings

fixes #1766

* fixup
2020-05-10 19:41:55 -07:00
Nolan Lawson
4b4cee3662
fix: fix delete-and-redraft in Firefox Android (#1762)
fixes #1681
2020-05-03 10:45:11 -07:00
Nolan Lawson
0c300f8e70
fix: change all opacity animation timings to 0.2s (#1753) 2020-04-30 21:54:07 -07:00
Nolan Lawson
4ad7de8e8d
fix: fix rendering order bug in Firefox for Android (#1752) 2020-04-29 22:00:20 -07:00
Nolan Lawson
0ce47f0379
fix: fix fade animations on slow devices (#1751)
I noticed that, on 6x CPU throttling in Chrome, the status fade-in animations were not consistent when switching columns. This fixes that using rAF.
2020-04-28 17:48:31 -07:00
Nolan Lawson
5f6c5d89d1
fix: only avoid scrollbar motion for prefers-reduced-motion (#1750)
After thinking about it, I do not believe the scrollbar is that distracting. But for prefers-reduced-motion we should be careful about the scrollbar growing so quickly.
2020-04-28 17:48:25 -07:00
Nolan Lawson
e1532ed9d1
perf: calculate plaintext from HTML content in advance in rIC (#1748)
On the Nexus 5 especially, this ensures we no longer have nearly so many
"long tasks" (i.e. responsiveness is better). It moves html-to-txt
calculation to the same step as blurhash decoding, where it can be done
in requestIdleCallback (heck, maybe someday it could just be done in a
worker thread as well).
2020-04-26 18:30:49 -07:00
Nolan Lawson
ae3bd2bda2
perf: make timeline rendering less janky (#1747)
* perf: make timeline rendering less janky

1. Ensures all statuses are rendered from top to bottom (no more shuffling-card-effect rendering)
2. Wraps all individual status renders in their own requestIdleCallback to improve input responsiveness especially only slow devices like Nexus 5.

* fix focus restoration

* only do rIC on mobile
2020-04-26 16:54:00 -07:00
Nolan Lawson
06a403df28
fix: left/right hotkey works on all settings page (#1745)
fixes #1744
2020-04-25 19:35:14 -07:00
Nolan Lawson
a4a9cb7962
fix: fix nav links in Voice Control on iOS (#1746)
fixes #1735
2020-04-25 19:35:03 -07:00
Nolan Lawson
1f0d67fcc4
feat: aria-labels and buttons contain more media info (#1743)
* feat: aria-labels and buttons contain more media info

fixes #1733

* fix lint
2020-04-25 19:03:39 -07:00
Nolan Lawson
912dda8778
fix: fix svelte dev warning about pinIndex (#1729) 2020-03-08 12:01:23 -07:00
Nolan Lawson
ec627f9732
fix: fix newlines in poll option titles (#1717) 2020-03-01 13:54:08 -08:00
Nolan Lawson
21a300bd4c
fix: remove intrinsicsize in favor of width/height (#1690) 2019-12-24 10:47:27 -08:00
Nolan Lawson
78014a7f33
fix: remove remount (#1688)
* fix: remove remount

* fixup
2019-12-23 18:10:03 -08:00
Nolan Lawson
22fd567eb1
fix: update emoji-mart, add dark mode and custom categories (#1686) 2019-12-23 11:53:44 -08:00
Nolan Lawson
56ab988d1a
fix: fix search width on narrow sizes (#1678) 2019-12-15 09:58:43 -08:00
Nolan Lawson
1d3859a4e2
fix: fix duplicates in threads (#1672)
fixes #943
2019-12-14 12:04:36 -08:00
Nolan Lawson
aa662682f3
fix: restore focus on community page (#1669) 2019-12-13 08:31:05 -08:00
Nolan Lawson
4f9fb5f253
fix: settings pages preserve focus (#1666)
fixes #1658
2019-12-08 18:03:26 -08:00
Nolan Lawson
c071ac1174
refactor: refactor focus management (#1662) 2019-11-30 17:43:31 -08:00
Nolan Lawson
cbbf5abd7a
test: test for DOM listener memory leaks (#1654)
* test: test for DOM listener memory leaks

* fix whitespace change, unintended
2019-11-23 23:42:22 -08:00
Nolan Lawson
fec0c282c9
fix: make autosuggest list appear over modal dialog (#1649)
fixes #1645
2019-11-23 13:21:21 -08:00
Nolan Lawson
4221ce1c72
fix: media nav buttons should be a list (#1648)
More work on #1633, improves accessibility of the media nav buttons by cleaning up the list and labels a bit.
2019-11-23 11:25:42 -08:00
Nolan Lawson
d03d223fd9
fix: remove aria-pressed entirely (#1647)
More progress on #1633
2019-11-23 11:25:36 -08:00
Nolan Lawson
1b95499008
fix: use radio buttons for pinning timelines (#1644)
* fix: use radio buttons for pinning timelines

more work on #1633

* cleanup styles
2019-11-17 23:02:05 -05:00
Nolan Lawson
568a3f51fe
fix: convert many toggle buttons into regular buttons (#1643)
work on #1633
2019-11-17 21:23:32 -05:00
Nolan Lawson
4903f2effa
perf: avoid aria-hidden="false" (#1640) 2019-11-17 20:51:44 -05:00
Nolan Lawson
92d77c34be
fix: use radiogroup for instance switcher (#1634)
* fix: use radiogroup for instance switcher

progress on #1633

* fixup

* add unique id
2019-11-17 20:51:28 -05:00
Nolan Lawson
63c9f8dc32
fix: fix autocomplete in voiceover+safari (#1632)
* fix: fix autocomplete in voiceover+safari

fixes #1629

* fix test

* fix test
2019-11-09 23:01:32 -05:00
Nolan Lawson
07facea505
fix: improve autosuggest a11y (#1630)
* fix: improve autosuggest a11y

some progress on #1629

- works in Chrome on NVDA now
- works in Chrome on VoiceOver now
- shorter aria-labels, don't repeat information like "1 of 3", because
it causes the screen reader to speak too frequently, e.g. when the
selected result hasn't changed but the number of results has. Also both
NVDA and VoiceOver already speak this information
- stop doing a fancy fade animation, just show and hide the input
instantly. I worry it confuses screen readers to have the aria-hidden
attribute in there at all
- stop using a single id to identify the active descendant - give
immutable IDs and then update the aria-activedescendant instead. I think
this is what fixed Chrome.

* fix test
2019-11-09 20:38:29 -05:00
Nolan Lawson
edc014cf8c
fix: more consistent toggle button aria-label/title (#1626)
* fix: more consistent toggle button aria-label/title

fixes #1624

* fixup

* fix test
2019-11-09 17:25:26 -05:00
Nolan Lawson
4ecb04588c
fix: fix custom emoji in polls (#1619)
fixes #1617
2019-10-31 23:01:35 -07:00
Nolan Lawson
ee492c1765
fix: change "add instance" to "log in" when not logged in (#1614) 2019-10-31 06:45:36 -07:00
Nolan Lawson
b8d9c29bac
perf: move async modules to individual files (#1611) 2019-10-29 18:58:49 -07:00
Nolan Lawson
7c04b86405
fix: use smooth scroll polyfill in Chrome for scroll-to-top (#1601)
* fix: use smooth scroll polyfill in Chrome for scroll-to-top

* rename thunk to __thunk__ for safety
2019-10-24 19:03:10 -07:00
Nolan Lawson
0194a07823
perf: use raw html for some external links (#1600) 2019-10-24 19:03:03 -07:00
Vincent
852a8582fb fix: Add the non-truncated text in the title attribute (#1598)
The `.card-title` element carries `text-overflow: ellipsis`, (and
`white-space: nowrap`), resulting in the last part of long article
titles not being visible. By adding it to the `title` attribute,
one can see the full title on hovering without having to visit the
article first.

The main concern I had was that the text is now technically
duplicated in the source code, and for short titles, also in the
UI. The primary concern there, however, was screen reader users
getting duplicate announcements. However, I believe the title
attribute is not announced by screen readers, which this (old)
article seems to confirm:
https://developer.paciellogroup.com/blog/2010/11/using-the-html-title-attribute/

That leaves the following two disadvantages:
- This doesn't solve anything for mobile users, who will still
  have to follow the link to see the full title.
- Desktop users can however a (non-truncated) title to see the same
  title again.
2019-10-23 21:54:57 -07:00
Nolan Lawson
01b0c43f0d
fix: remove type="*" from videos (#1593) 2019-10-17 18:27:30 -07:00
Nolan Lawson
d663dd7fe8
fix: fix wasted space in options dialog (#1585)
fixes #1487
2019-10-15 19:35:00 -07:00
Nolan Lawson
67b71231d3
fix: use short usernames in options dialog (#1576) 2019-10-15 07:56:39 -07:00
Nolan Lawson
d580a9b7e8
fix: do not prefer lowercase for hashtags in search (#1571) 2019-10-13 10:49:39 -07:00
Nolan Lawson
8b3842f15a
feat: add hashtag autocomplete (#1567)
* feat: add hashtag autocomplete

fixes #1209

* add test and tweak aria label and styles

* do not prefer lowercase

* Change text
2019-10-12 18:06:04 -07:00